Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra insurance that we don't mix events in the wrong timelines - v2 #2856

Merged
merged 10 commits into from
Nov 7, 2022

Commits on Nov 4, 2022

  1. Configuration menu
    Copy the full SHA
    0f0e8f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    58ed2f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b91b03b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7fd36a4 View commit details
    Browse the repository at this point in the history
  5. Only run canContain for room timelines

    Fix test failure in `sliding-sync/sliding-sync.ts` -> `"should show the right unread notifications"`
    
    ```
    Cannot call `EventTimelineSet::canContain without a `room` set. Set the room when creating the EventTimelineSet to call this method.
        at EventTimelineSet.canContain (VM4503 200:726:13)
        at EventTimelineSet.addEventToTimeline (VM4503 200:576:15)
        at EventTimelineSet.addLiveEvent (VM4503 200:527:10)
        at eval (VM4587 281:722:145)
        at Array.forEach (<anonymous>)
        at SlidingSyncSdk.purgeNotifications (VM4587 281:720:22)
        at SlidingSyncSdk.onLifecycle (VM4587 281:263:14)
        at SlidingSync.emit (VM4407 21:153:5)
        at SlidingSync.emit (VM4472 169:45:18)
        at SlidingSync.invokeLifecycleListeners (VM4588 282:378:10)
    ```
    MadLittleMods committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    52d4280 View commit details
    Browse the repository at this point in the history
  6. More info in error

    MadLittleMods committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    a1449f9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3109e28 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f2f37e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Remove fit

    MadLittleMods committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ded1433 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3b6f4f View commit details
    Browse the repository at this point in the history