Fix race in creating calls #2663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second attempt, just put a mutex around the method that processes member state events. Also more logging. Supersedes #2662
| @@ -185,6 +185,9 @@ export class GroupCall extends TypedEventEmitter< | |||
| private resendMemberStateTimer: ReturnType<typeof setInterval> | null = null; | |||
| private initWithAudioMuted = false; | |||
| private initWithVideoMuted = false; | |||
| // We use this as a set of mutexes, effectively, to make sure we only enter the function | |||
| // to process a member state event once at any one time for each member | |||
| private processingMemberStateEvent = new Map<string, boolean>(); | |||
There was a problem hiding this comment.
Why is this a map? Wouldn't a Set work?
Comment on lines
+773
to
+777
| try { | ||
| return this.processMemberStateEventInternal(event); | ||
| } finally { | ||
| this.processingMemberStateEvent.delete(event.getStateKey()); | ||
| } |
There was a problem hiding this comment.
What's the benefit of try/finally here?
|
Also, what if the event changes while we're processing it? |
|
Hmm, yes, you're right. We need to handle the newer ones somehow. |
|
Going back to #2662 again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt, just put a mutex around the method that processes member state events. The previous change meant that uninitialised calls were sitting in the map which is not a thing this code is prepared to handle and was causing test failures.
Also more logging.
Supersedes #2662
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes