Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with duplicated MatrixEvent objects around threads #2256

Merged
merged 20 commits into from
Mar 24, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 23, 2022

Fixes element-hq/element-web#21466
Believably fixes element-hq/element-web#21533


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me!

src/event-mapper.ts Show resolved Hide resolved
@t3chguy t3chguy requested a review from germain-gg March 23, 2022 15:59
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thank you for the tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #2256 (8fd3d24) into develop (6192325) will increase coverage by 0.16%.
The diff coverage is 77.14%.

❗ Current head 8fd3d24 differs from pull request most recent head 6b63ddd. Consider uploading reports for the commit 6b63ddd to get more accurate results

@@             Coverage Diff             @@
##           develop    #2256      +/-   ##
===========================================
+ Coverage    58.38%   58.55%   +0.16%     
===========================================
  Files           91       91              
  Lines        16313    16285      -28     
  Branches      3763     3758       -5     
===========================================
+ Hits          9525     9535      +10     
+ Misses        6788     6750      -38     
Impacted Files Coverage Δ
src/models/thread.ts 53.91% <50.00%> (-2.13%) ⬇️
src/models/room.ts 54.65% <70.00%> (+2.52%) ⬆️
src/client.ts 36.65% <100.00%> (-0.03%) ⬇️
src/event-mapper.ts 95.45% <100.00%> (+1.33%) ⬆️
src/models/event.ts 66.58% <100.00%> (+0.24%) ⬆️
src/@types/event.ts 100.00% <0.00%> (ø)

@t3chguy t3chguy merged commit c541b3f into develop Mar 24, 2022
@t3chguy t3chguy deleted the t3chguy/fix/21466 branch March 24, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants