Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An attempt to cleanup how constraints are handled in calls #1613

Merged
merged 9 commits into from
Mar 3, 2021
Merged

An attempt to cleanup how constraints are handled in calls #1613

merged 9 commits into from
Mar 3, 2021

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Feb 23, 2021 •
edited
Loading

This is an attempt to make the handling of constraints a bit cleaner. It should also be useful for implementing midcall device changes.

@dbkr is probably the best reviewer for this.

@SimonBrandner
Add screenshare type to getUserMediaContraints()
ba58d3c 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Simplifie placeScreenSharingCall()
20eaba1 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Set video to true
20afebf 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Add AudioVideo constraint type
5849ea8 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner marked this pull request as draft February 23, 2021 11:38
@SimonBrandner SimonBrandner marked this pull request as ready for review February 23, 2021 11:45
@SimonBrandner SimonBrandner changed the title An attempt to cleanup how constraints are handled An attempt to cleanup how constraints are handled in calls Feb 23, 2021
@jryans jryans requested a review from a team February 27, 2021 15:11
@SimonBrandner
Add getScreenshareContraints()
e756289 
This is nicer since we avoid some async functions

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Pass in selectDesktopCapturerSource()
0c94ee6 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@jryans jryans requested review from dbkr and removed request for a team March 2, 2021 13:53
@SimonBrandner SimonBrandner marked this pull request as draft March 3, 2021 10:51
@SimonBrandner
Merge branch 'develop' into constraint-cleanup
32e19ea
@SimonBrandner
Remove AudioVideo ConstraintsType
4275002 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Null-check screenshareConstraints
f0b2d2f 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner marked this pull request as ready for review March 3, 2021 14:43
@SimonBrandner SimonBrandner requested a review from dbkr March 3, 2021 14:43
@dbkr dbkr merged commit e531456 into matrix-org:develop Mar 3, 2021
@SimonBrandner SimonBrandner deleted the constraint-cleanup branch March 3, 2021 15:04
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonBrandner @dbkr