Avoid paginating forever in private rooms #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TimelineWindow.paginate, keep a count of the number of API requests we have made, and bail out if it gets too high, to ensure that we don't get stuck in a loop of paginating right back to the start of the room.
|
(this is waiting for the react-sdk PR) |
|
This goes together with #124. |
| if (!makeRequest) { | ||
| if (!makeRequest || requestLimit === 0) { | ||
| // todo: should we return something different to indicate that there | ||
| // might be more envets out there, but we haven't found them yet? |
|
otherwise lgtm |
|
ta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TimelineWindow.paginate, keep a count of the number of API requests we have
made, and bail out if it gets too high, to ensure that we don't get stuck in a
loop of paginating right back to the start of the room.