Wait for received events using /sync in faster room joins tests #441
Conversation
@richvdh Is this expected behaviour? |
It's expected that outliers don't come down |
| getSyncToken := func(t *testing.T, alice *client.CSAPI) string { | ||
| _, syncToken := alice.MustSync(t, | ||
| client.SyncReq{ | ||
| Filter: buildLazyLoadingSyncFilter(nil), |
There was a problem hiding this comment.
I think you probably don't need a Filter?
There was a problem hiding this comment.
Won't that make the function block if we decide to use it midway through a partial join?
There was a problem hiding this comment.
yes, but I didn't think this was used in the middle of a partial-state join?
(indeed, I thought initialsyncs in the middle of partial-state joins blocked irrespective of the lazy-loading flag. I'm probably wrong though)
There was a problem hiding this comment.
It isn't currently used in the middle of a partial-state join, but I would like to keep the option open.
lazy-loading initial syncs don't (or no longer?) block during a partial-state join, otherwise one of the new lazy-loading tests in #442 would be getting stuck.
squahtx
deleted the
squah/faster_room_joins_unblock_lazy_loading_sync_1
branch
These broke during the merge of #441.
matrix-org/synapse#13477 unblocks lazy-loading
/syncs while a room has partial state, which allows us to wait forreceived events using
/sync."Resync completes even when events arrive before their prev_events" is
now the only test that waits for events using
/event, since theoutliers do not appear in the
/synctimeline.