Always mount CA certificates and keys using in-memory files #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `VolumeCA` as we don't mount the file as a volume anymore. - Remove `COMPLEMENT_CA` as we always mount regardless of whether or not the Homeserver image uses it. - Rejig when and where the CA cert/key is made. Now it is automatically made when a `config.Complement` is made. - Remove unused/redundant params for `deployImage`.
neilalexander
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VolumeCAas we don't mount the file as a volume anymore.COMPLEMENT_CAas we always mount regardless of whether or not the Homeserver image uses it.config.Complementis made.deployImage.This can be optimised further. Currently, every time an image is deployed we inject the CA files. It would be sneakier to just do this once when a blueprint is made, so that way the files are already there when we deploy the container.
Fixes #65