Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Spaces Summary tests (MSC2946) to match the current spec #101

Merged
merged 4 commits into from
Apr 9, 2021

Conversation

clokep
Copy link
Member

@clokep clokep commented Apr 8, 2021

This fixes matrix-org/synapse#9756 by updating the Complement tests to match the current specification. The main differences are:

  • There's no longer a limit flag.
  • The summary only travels "down" to children rooms from the given root.
  • The path specifies the unstable identifier in it.

Note that this won't break Dendrite because Dendrite was not passing the tag to run these tests.

@clokep
Copy link
Member Author

clokep commented Apr 8, 2021

Vaguely related to matrix-org/pipelines#139 in that these tests can now be enabled for Synapse.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems plausible to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable spaces summary (MSC2946) tests in complement
3 participants