Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SVT-AV1 target quality params for v0.9.0 #557

Merged
merged 4 commits into from
Jan 30, 2022

Conversation

redzic
Copy link
Collaborator

@redzic redzic commented Jan 23, 2022

Should fix #556, although now target quality won't work for SVT-AV1 <0.9.0 as we use preset 12. Not sure if we should use preset 8 instead by default as it did before, as SVT-AV1 0.9.0 was released quite recently so people may not have had enough time to update to it yet

@shssoichiro
Copy link
Collaborator

shssoichiro commented Jan 23, 2022

Maybe we run a version check by parsing SvtAv1Enc --help to determine which to use? Arch doesn't even have 0.9.0 yet, so this probably breaks about 98% of people.

@silverbacknet
Copy link

--version but yes, absolutely critical given the huge reorganization between 0.8.8 and 0.9.0. If you ever feel like switching to the API, it's very easy to get there too, via svt_av1_get_version().

@redzic
Copy link
Collaborator Author

redzic commented Jan 30, 2022

@shssoichiro I've updated this PR to include a version check for SVT

@shssoichiro
Copy link
Collaborator

Do we also need to update the parameter validation?

@redzic
Copy link
Collaborator Author

redzic commented Jan 30, 2022

The parameter validation is dynamic, i.e. it parses the correct parameters at runtime based on --help output, so it shouldn't need updating.

Copy link
Collaborator

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming CI passes

@mergify mergify bot merged commit e7b2d08 into master-of-zen:master Jan 30, 2022
@redzic redzic deleted the fix-svt branch January 30, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--encoder svt-av1 --target-quality fails with v0.9.0
3 participants