Proposition: Refactor whitelist peers #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
changed the title
adrien-zinger
approved these changes
Mar 7, 2022
|
I let you merge it on your PR whenever you want @AureliaDolo |
|
beautiful ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made this pull request to give my proposal on how to improve the PR #2297 . The PR responds to those problems :
EnumMap(https://crates.io/crates/enum-map) and so you can add more variant to the enum and it will scale the whole process. It will simplify the implementation of Make PeerType arbitrary (from string ?) #2334.