Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed deprecated messageformat #472

Merged
merged 4 commits into from
Jan 23, 2022
Merged

fix: removed deprecated messageformat #472

merged 4 commits into from
Jan 23, 2022

Conversation

calmonr
Copy link
Contributor

@calmonr calmonr commented Jun 6, 2021

The package messageformat has been deprecated in favor of @messageformat/core.

@coveralls
Copy link

coveralls commented Jun 6, 2021

Coverage Status

Coverage decreased (-0.003%) to 97.963% when pulling 03b20b5 on calmonr:fix-messageformat into 494a464 on mashpie:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 96.102% when pulling 037169e on calmonr:fix-messageformat into 494a464 on mashpie:master.

@calmonr calmonr marked this pull request as draft June 6, 2021 17:27
@calmonr
Copy link
Contributor Author

calmonr commented Jun 6, 2021

@mashpie There might be breaking changes for a few people (as the validation for unused plural keys was disabled by default):

mf.disablePluralKeyChecks()

PRs explaining the reasons:

messageformat/messageformat#244
messageformat/messageformat#290

cc @eemeli

@calmonr calmonr marked this pull request as ready for review June 6, 2021 23:31
@mashpie
Copy link
Owner

mashpie commented Jun 7, 2021

Thanks @calmonr for your effort. I‘ll take some time to review those breaking changes carefully - would be the 1st break in 10 years;)

@mashpie
Copy link
Owner

mashpie commented Dec 29, 2021

I should try to keep test cases with real mf strings in json files, Russian for example plurals are complex and should still work.

@niftylettuce
Copy link
Contributor

@mashpie I just sponsored you on GitHub - hopefully you can get this resolved so we can no longer have the dep warning!

@mashpie
Copy link
Owner

mashpie commented Jan 14, 2022

@niftylettuce ! Thank you so much :)

@niftylettuce
Copy link
Contributor

Of course @mashpie, without this project, https://forwardemail.net wouldn't have localization!

@mashpie
Copy link
Owner

mashpie commented Jan 19, 2022

This is a nice testimonial! Note to myself: … should collect them.

@mashpie mashpie merged commit 0faeee0 into mashpie:master Jan 23, 2022
@mashpie
Copy link
Owner

mashpie commented Jan 23, 2022

@calmonr Thanks for PR
@niftylettuce here you go :)

https://github.com/mashpie/i18n-node/releases/tag/0.14.0

❯ yarn add i18n
yarn add v1.22.17
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
success Saved lockfile.
success Saved 14 new dependencies.
info Direct dependencies
└─ i18n@0.14.0
info All dependencies
├─ @messageformat/core@3.0.0
├─ @messageformat/date-skeleton@1.0.0
├─ @messageformat/number-skeleton@1.0.0
├─ @messageformat/parser@5.0.0
├─ @messageformat/runtime@3.0.0
├─ boolean@3.1.4
├─ debug@4.3.3
├─ fast-printf@1.6.9
├─ i18n@0.14.0
├─ math-interval-parser@2.0.1
├─ moo@0.5.1
├─ ms@2.1.2
├─ mustache@4.2.0
└─ safe-identifier@0.4.2
✨  Done in 4.58s.

@calmonr calmonr deleted the fix-messageformat branch January 24, 2022 04:29
@calmonr
Copy link
Contributor Author

calmonr commented Jan 24, 2022

@mashpie You're most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants