Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark 'should' and 'zombie' as devDependencies #446

Merged
merged 1 commit into from
Aug 21, 2020
Merged

fix: mark 'should' and 'zombie' as devDependencies #446

merged 1 commit into from
Aug 21, 2020

Conversation

DRoet
Copy link
Contributor

@DRoet DRoet commented Aug 21, 2020

I noticed a lot more dependencies were being pulled in after upgrading to version 0.13.x. Since should and zombie are only being used in development we should probably mark them as devDependencies

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.966% when pulling 5b6444f on DRoet:master into f2145ab on mashpie:master.

@mashpie
Copy link
Owner

mashpie commented Aug 21, 2020

true... how could I miss this. Your package lock is resolving vulnerable lodash... anyway I'll fix that

@mashpie mashpie merged commit 1246632 into mashpie:master Aug 21, 2020
@mashpie
Copy link
Owner

mashpie commented Aug 21, 2020

...and published

@DRoet
Copy link
Contributor Author

DRoet commented Aug 21, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants