When level is unknown, don't go up but wait for a first setLevel command #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow LEVEL_NONE as valid in the StoredState. At initialization, don't go up immediately, but wait for a setLevel command that is 0 or 100 to start moving. Only then, go to the STATE_RESETTING state. When in STATE_RESETTING state, don't accept other setLevel or stop commands until the move is finished, that is we are back in STATE_IDLE with a known level.
|
@marvinroger I beg you, please merge this PR :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow LEVEL_NONE as valid in the StoredState.
At initialization, don't go up immediately, but wait for a setLevel
command that is 0 or 100 to start moving.
Only then, go to the STATE_RESETTING state.
When in STATE_RESETTING state, don't accept other setLevel or
stop commands until the move is finished, that is we are back in
STATE_IDLE with a known level.