Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build with gcc 4.9 as the first version of find() can't be constexpr then #54

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

DerDakon
Copy link
Contributor

@DerDakon DerDakon commented Oct 19, 2022

The build error is:

  string_view.hpp:859:5: error: body of constexpr function 'constexpr nonstd::sv_lite::basic_string_view<CharT, Traits>::size_type nonstd::sv_lite::basic_string_view<CharT, Traits>::find(nonstd::sv_lite::basic_string_view<CharT, Traits>, nonstd::sv_lite::basic_string_view<CharT, Traits>::size_type) const [with CharT = char; Traits = std::char_traits<char>; nonstd::sv_lite::basic_string_view<CharT, Traits>::size_type = unsigned int]' not a return-statement

…xpr then

The build error is:

  string_view.hpp:859:5: error: body of constexpr function 'constexpr nonstd::sv_lite::basic_string_view<CharT, Traits>::size_type nonstd::sv_lite::basic_string_view<CharT, Traits>::find(nonstd::sv_lite::basic_string_view<CharT, Traits>, nonstd::sv_lite::basic_string_view<CharT, Traits>::size_type) const [with CharT = char; Traits = std::char_traits<char>; nonstd::sv_lite::basic_string_view<CharT, Traits>::size_type = unsigned int]' not a return-statement
@DerDakon DerDakon changed the title fix build with gcc 4.9 as the first version of find() can't be conste… fix build with gcc 4.9 as the first version of find() can't be constexpr then Oct 19, 2022
@martinmoene martinmoene merged commit cc67e97 into martinmoene:master Oct 20, 2022
@DerDakon DerDakon deleted the cpp14-find-constexpr branch October 20, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants