Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless UUID._serialize override #1489

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Remove useless UUID._serialize override #1489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a969e15
Remove useless UUID._serialize override
lafrech Jan 12, 2020
cad9c8f
Update CHANGELOG
lafrech Jan 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Changelog
Features:

- Improve type coverage (:issue:`1479`). Thanks :user:`Reskov`.
- Remove useless ``_serialize`` override in ``UUID`` field (:pr:`1489`).

3.3.0 (2019-12-05)
******************
Expand Down
4 changes: 0 additions & 4 deletions src/marshmallow/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,10 +865,6 @@ def _validated(self, value) -> typing.Optional[uuid.UUID]:
except (ValueError, AttributeError, TypeError) as error:
raise self.make_error("invalid_uuid") from error

def _serialize(self, value, attr, obj, **kwargs) -> typing.Optional[str]:
val = str(value) if value is not None else None
return super()._serialize(val, attr, obj, **kwargs)

def _deserialize(self, value, attr, data, **kwargs) -> typing.Optional[uuid.UUID]:
return self._validated(value)

Expand Down