Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to remove C 11 Generic Macros or fix build system #41

Open
markplagge opened this issue Jun 13, 2017 · 3 comments
Open

Need to remove C 11 Generic Macros or fix build system #41

markplagge opened this issue Jun 13, 2017 · 3 comments

Comments

@markplagge
Copy link
Owner

Currently NeMo uses C11 generic macros for file writes and for debug printing. Due to lack of support of this feature, we should remove these macros and replace them with standard functions or change the build system to handle the lack of _generic support.
The BGQ compiler supports _generic, but it is implemented in a different way than GCC. Clang and GCC differ in their implementation and handling of char*.

@carothersc-zz
Copy link
Collaborator

carothersc-zz commented Jun 13, 2017 via email

@markplagge
Copy link
Owner Author

markplagge commented Jun 13, 2017

C11 - Removing features in progress

@carothersc-zz
Copy link
Collaborator

carothersc-zz commented Jun 13, 2017 via email

markplagge pushed a commit that referenced this issue Jun 14, 2017
From Niel's commit: #6bfe9f0b8b59306a07f186c557f4e13d428fa7f2
@6bfe9f0b8b59306a07f186c557f4e13d428fa7f2

I manually pulled his changes into this branch, basically taking his vis-integration branch to the top of dev. Currently running tests to see if his code works.

ALSO - Removed C11 specific features from NeMo. This is part 1 for issue #41.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants