-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to remove C 11 Generic Macros or fix build system #41
Comments
Yeah - stick with nothing more than C99 standard stuff. The C11 extensions
are not well supported in a standard way :-)>
Happy hacking ..
Chris
…On Tue, Jun 13, 2017 at 11:21 AM, Mark Plagge ***@***.***> wrote:
Currently NeMo uses C11 generic macros for file writes and for debug
printing. Due to lack of support of this feature, we should remove these
macros and replace them with standard functions or change the build system
to handle the lack of _generic support.
The BGQ compiler supports _generic, but it is implemented in a different
way than GCC. Clang and GCC differ in their implementation and handling of
char*.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#41>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA9Uk31D5UoK05bbORNsQMftOdpka8s5ks5sDqjigaJpZM4N4p1o>
.
--
----------------------------------------------------------------------------------------------
Christopher D. Carothers
Director, Center for Computational Innovations
Professor, Department of Computer Science
Rensselaer Polytechnic Institute
110 8th Street
Troy, New York 12180-3590
e-mail: chris.carothers@gmail.com
web page: www.cs.rpi.edu/~chrisc <http://www.cs.rpi.edu/%7Echrisc>
phone: (518) 276-2930
fax: (518) 276-4033
----------------------------------------------------------------------------------------------
|
C11 - Removing features in progress |
Leason learned ! :-)
…On Tue, Jun 13, 2017 at 11:25 AM, Mark Plagge ***@***.***> wrote:
The new features are very sexy, but the amount of time I saved writing
code using the _generic code is turning out to be WAY less than the amount
of time I have spent getting it to compile with these new features 👍
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#41 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA9Uk6n8m8ILjk1yedzOmEVfXHxhFhWQks5sDqnhgaJpZM4N4p1o>
.
--
----------------------------------------------------------------------------------------------
Christopher D. Carothers
Director, Center for Computational Innovations
Professor, Department of Computer Science
Rensselaer Polytechnic Institute
110 8th Street
Troy, New York 12180-3590
e-mail: chris.carothers@gmail.com
web page: www.cs.rpi.edu/~chrisc <http://www.cs.rpi.edu/%7Echrisc>
phone: (518) 276-2930
fax: (518) 276-4033
----------------------------------------------------------------------------------------------
|
markplagge
pushed a commit
that referenced
this issue
Jun 14, 2017
From Niel's commit: #6bfe9f0b8b59306a07f186c557f4e13d428fa7f2 @6bfe9f0b8b59306a07f186c557f4e13d428fa7f2 I manually pulled his changes into this branch, basically taking his vis-integration branch to the top of dev. Currently running tests to see if his code works. ALSO - Removed C11 specific features from NeMo. This is part 1 for issue #41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently NeMo uses C11 generic macros for file writes and for debug printing. Due to lack of support of this feature, we should remove these macros and replace them with standard functions or change the build system to handle the lack of _generic support.
The BGQ compiler supports _generic, but it is implemented in a different way than GCC. Clang and GCC differ in their implementation and handling of char*.
The text was updated successfully, but these errors were encountered: