Update to the new Akinator API #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project won't compile in its current state
The patch is nearing completion (assuming no issues during testing), docs still need a lot of work.
|
TODO: Only call IntegrationTest in the cron workflow |
The game is now in a playable state
While Akinator will sometimes awkwardly propose the same guess multiple times in a row, ignoring such guesses means we repeat the same question number multiple times (since the step doesn't increment after a guess). I've opted to do what the website does, which is of course to annoy the user by proposing the same guess multiple times.
Since we call methods on Query objects now, this situation can't happen anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #20
Roadmap