Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warnings for using render methods when you want string output #450

Merged
merged 7 commits into from
Nov 30, 2016

Conversation

mlrawlings
Copy link
Member

@mlrawlings mlrawlings commented Nov 29, 2016

Description

Deprecate renderSync(data) and render(data, callback) in their current forms. Use renderToString instead as v4 will return a RenderResult instead of a string.

Motivation and Context

With this notice in place, there shouldn't be any breaking changes when moving from v3 to v4 that don't already warn you in the current version.

Checklist:

  • My code follows the code style of this project.
  • I have updated/added documentation affected by my changes.
  • I have read the CONTRIBUTING document.
  • No new tests, changes already covered by existing tests.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Nov 29, 2016

Coverage Status

Coverage increased (+0.03%) to 84.019% when pulling 99e7873 on v3-render-to-string into 91c215c on v3.

@patrick-steele-idem patrick-steele-idem merged commit 591b912 into v3 Nov 30, 2016
eikaramba added a commit to eikaramba/consolidate.js that referenced this pull request Dec 29, 2016
Marko changed its implementation and thus "The render callback will no longer receive a string in Marko v4. Use `renderToString(data, callback)` instead" See marko-js/marko#450.

This change is compatible with the current stable public version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants