Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol, FQDN, Port specification #1

Closed
RamblingCookieMonster opened this issue May 8, 2015 · 2 comments
Closed

Protocol, FQDN, Port specification #1

RamblingCookieMonster opened this issue May 8, 2015 · 2 comments

Comments

@RamblingCookieMonster
Copy link

Hi Marius!

Great job with this module, it's quite handy, was a helpful interface to getting a feel for working with RabbitMQ.

I'm rolling this out to production, which means (for us) SSL. I'll be working on this a bit to mold it to meet our needs - would you be interested in pull requests, or prefer to keep your project as-is?

If you are interested, let me know! Have a few POC changes made at the fork:

  • Renamed files with public functions to reflect function names (export-modulemember can thus just look at file basename)
  • Moved private functions to subfolder
  • Moved scriptstoprocess to a subfolder
  • Removed username / password option (generally a bad practice, don't want to give my folks the option : ) )
  • Changed ComputerName to BaseUri (i.e. https://fq.dn:port) and cascaded changes where I could find them (not property names, those still say computername) - not sure if having a Protocol, FQDN, and Port separately would be preferable, went with the simplest approach.

Either way, this is incredibly handy - Thanks again!

@mariuszwojcik
Copy link
Owner

Hi Warren

Glad you like RabbitMQTools. I had a look at your fork, but am afraid there are breaking changes for me to accept it. I know there are people using this module in their automation scripts. And, event though it is not a good option to pass username and password, they are doing it. I like the way you organised files. Once I get a break, I will probably apply that to the code base.

Cheers,

Mariusz

@RamblingCookieMonster
Copy link
Author

Hi Mariusz,

Makes sense - I'll close this out.

Apologies for misspelling your name, and thanks again for the great module!

Warren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants