Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Conflicting configs #11

Open
margual56 opened this issue Sep 27, 2023 · 1 comment
Open

[BUG] - Conflicting configs #11

margual56 opened this issue Sep 27, 2023 · 1 comment
Assignees
Labels
Backend Affects the Backend in Rust bug Something isn't working
Milestone

Comments

@margual56
Copy link
Owner

Bug description

When adding a new attribute to the config, it fails to parse (as it should).

This needs a long-term fix.

To Reproduce

  1. Add a new attribute or modify an attribute of the config.
  2. Load the app
  3. Watch it crash

Expected behavior

Maybe it could rename your old config as "*.bak" and replace it with an empty one.

Another option is to implement a versioning scheme and a custom deserializer that can deserialize any version and updates the config automatically. This would be the preferred solution

Screenshots

N/A

Information

  • OS: N/A
  • Program version: N/A

Additional context
N/A

@margual56 margual56 added bug Something isn't working Backend Affects the Backend in Rust labels Sep 27, 2023
@margual56 margual56 self-assigned this Sep 27, 2023
@margual56
Copy link
Owner Author

For the moment, as a temporary fix, I make it override the previous config.

This is preferable to the app crashing without displaying any errors.

margual56 added a commit that referenced this issue Sep 27, 2023
margual56 added a commit that referenced this issue Sep 27, 2023
* fix: Miscalculation on yearly costs

* fix: Typo on recurrences

* fix: bug #10; temporary fix for bug #11

* Fix: bug #6, solution is untested

* Run cargo fmt

* Fix: issue #7

* Bump version
@margual56 margual56 added this to the v0.2.0 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Affects the Backend in Rust bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant