Bug 1500436 - Redirect node.js's stderr to a pipe. r=froydnj

This works around nodejs/node#14752, which
causes problems with make.

Differential Revision: https://phabricator.services.mozilla.com/D35986

UltraBlame original commit: 562655fedb9df034ae1f8c32cd730f6498d501a7

python/mozbuild/mozbuild/action/node.py

@@ -368,13 +368,106 @@
 (
 )
 
-output
+#
+We
+need
+to
+redirect
+stderr
+to
+a
+pipe
+because
+
+#
+https
+:
+/
+/
+github
+.
+com
+/
+nodejs
+/
+node
+/
+issues
+/
+14752
+causes
+issues
+with
+make
+.
+
+proc
 =
 subprocess
 .
-check_output
+Popen
 (
+
 node_cmd_list
+stdout
+=
+subprocess
+.
+PIPE
+stderr
+=
+subprocess
+.
+PIPE
+)
+
+stdout
+stderr
+=
+proc
+.
+communicate
+(
+)
+
+retcode
+=
+proc
+.
+wait
+(
+)
+
+if
+retcode
+!
+=
+0
+:
+
+print
+(
+stderr
+file
+=
+sys
+.
+stderr
+)
+
+sys
+.
+stderr
+.
+flush
+(
+)
+
+sys
+.
+exit
+(
+retcode
 )
 
 #
@@ -422,7 +515,7 @@
 for
 line
 in
-output
+stdout
 .
 splitlines
 (