Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Labeling colors #221

Merged
merged 8 commits into from
Jun 27, 2018
Merged

Change Labeling colors #221

merged 8 commits into from
Jun 27, 2018

Conversation

Shashi456
Copy link
Contributor

@Shashi456 Shashi456 commented Jun 22, 2018

Fixes #212.

@Shashi456
Copy link
Contributor Author

capture

@Shashi456
Copy link
Contributor Author

@marco-c should i make a seperate pr to reflect the changes in readme.md? we would need to change the images

@codecov-io
Copy link

codecov-io commented Jun 22, 2018

Codecov Report

Merging #221 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #221   +/-   ##
======================================
  Coverage    20.8%   20.8%           
======================================
  Files          11      11           
  Lines        1216    1216           
  Branches      160     160           
======================================
  Hits          253     253           
  Misses        961     961           
  Partials        2       2
Impacted Files Coverage Δ
label.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee76d3...268f14c. Read the comment docs.

@sagarvijaygupta
Copy link
Collaborator

sagarvijaygupta commented Jun 22, 2018

@Shashi456 If you wish you can try Adobe Color Wheel. I am pretty bad at colors even after using this.

@Shashi456
Copy link
Contributor Author

@sagarvijaygupta i will check it out thank you

@marco-c
Copy link
Owner

marco-c commented Jun 22, 2018

@marco-c should i make a seperate pr to reflect the changes in readme.md? we would need to change the images

No, we should change them at the same time, otherwise we leave the repository in an inconsistent state.

@Shashi456
Copy link
Contributor Author

image

@@ -86,9 +86,9 @@ For the unsupervised training, we are using a related problem for which we alrea

```
-network To select which network architecture to use

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These whitespace changes are unrelated, could you remove them from the patch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no idea why this keeps happening. I didn't touch this part of the file at all. i tried to revise this but this still keep popping up

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably your text editor doing this automatically. It's OK, let's ignore it.

@@ -29,7 +29,7 @@
box_to_change = {}
all_boxes = {}
key_map = {'Escape': 27, 'r': 114, 'Enter': 13, 'Space': 32, 'y': 121, 'left_a': 97, 'right_d': 100}
COLOR_N = (0, 255, 0) # GREEN
COLOR_N = (128, 0, 128) # PURPLE
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the help text at the bottom of the file too.

@marco-c marco-c merged commit b18eae0 into marco-c:master Jun 27, 2018
@propr
Copy link

propr bot commented Jun 27, 2018

Please provide your feedback on this pull request here.

Privacy statement: We don't store any personal information such as your email address or name. We ask for GitHub authentication as an anonymous identifier to account for duplicate feedback entries and to see people specific preferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants