-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Labeling colors #221
Conversation
@marco-c should i make a seperate pr to reflect the changes in readme.md? we would need to change the images |
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
======================================
Coverage 20.8% 20.8%
======================================
Files 11 11
Lines 1216 1216
Branches 160 160
======================================
Hits 253 253
Misses 961 961
Partials 2 2
Continue to review full report at Codecov.
|
@Shashi456 If you wish you can try |
@sagarvijaygupta i will check it out thank you |
No, we should change them at the same time, otherwise we leave the repository in an inconsistent state. |
@@ -86,9 +86,9 @@ For the unsupervised training, we are using a related problem for which we alrea | |||
|
|||
``` | |||
-network To select which network architecture to use | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These whitespace changes are unrelated, could you remove them from the patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have no idea why this keeps happening. I didn't touch this part of the file at all. i tried to revise this but this still keep popping up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably your text editor doing this automatically. It's OK, let's ignore it.
@@ -29,7 +29,7 @@ | |||
box_to_change = {} | |||
all_boxes = {} | |||
key_map = {'Escape': 27, 'r': 114, 'Enter': 13, 'Space': 32, 'y': 121, 'left_a': 97, 'right_d': 100} | |||
COLOR_N = (0, 255, 0) # GREEN | |||
COLOR_N = (128, 0, 128) # PURPLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the help text at the bottom of the file too.
Please provide your feedback on this pull request here. Privacy statement: We don't store any personal information such as your email address or name. We ask for GitHub authentication as an anonymous identifier to account for duplicate feedback entries and to see people specific preferences. |
Fixes #212.