Improve diagnostics #403
Closed
Improve diagnostics #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diagnostic was added to the diagnostics list, but never actually computed. I added an additional near_surface_integral argument to where we compute the per-autotroph photoC_NO3_zint (full depth integral), and the sum of those near_surface_integral values is the _100m equivalent.
frequency was changed from 'none' to 'medium' because this value is useful for forcing FEISTY and it would be nice to just have it in typical CESM output
I was seeing an error that was introduced with jinja2 v3.0 in the CI, so I require <3 in the pip requirements file. In a sandbox, I was then seeing an error from MarkupSafe and it turns out that was introduced in v2.1 so I require <2.1 in the pip file. I also updated the github action to (hopefully) run the Fortran test suite even if building the documentation fails
a3dde53 changed the value of photoC_NO3_TOT_zint_100m from 0 to the actual integral that should be computed, and we need those correct values in the baseline for testing purposes.
This was
linked to
issues
May 10, 2022
|
After talking with @klindsay28, we thought the best plan would be to
I'm going to close this PR, and will open a new one (or two) next week, depending on how the conversation goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two small issues with diagnostics:
photoC_NO3_TOT_zint_100mwas being defined but never computed)pocToFlooris now output in themediumstream by default)For the first, I opted to compute
photoC_NO3_TOT_zint_100mrather than remove it from the diagnostic list.There are two small issues remaining to address:
tests/regression_tests/call_compute_subroutines/sphinxwe are using for the docs and a major version update ofjinja2.I'll remove draft status from this PR after fixing those two minor issues.