Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

photoC_NO3_TOT_zint_100m diagnostic not computed #401

Open
klindsay28 opened this issue Apr 26, 2022 · 0 comments
Open

photoC_NO3_TOT_zint_100m diagnostic not computed #401

klindsay28 opened this issue Apr 26, 2022 · 0 comments

Comments

@klindsay28
Copy link
Collaborator

In recent MOM vs POP MARBL comparison runs, I noticed that photoC_NO3_TOT_zint_100m is all zeros.

Digging into the code and commit history, I see that I added a declaration for photoC_NO3_TOT_zint_100m in e7deac5, but did not add code to compute the diagnostic.

I guess we haven't looked at this diagnostic. It is not a CMIP diagnostic, while the related diagnostic photoC_NO3_TOT_zint is.

I'm not sure if we should remove photoC_NO3_TOT_zint_100m or add code to compute it.

I'm leaning towards the former, given that this issue hasn't been noticed in the 4 years since the diagnostic was added.
@mnlevy1981 mnlevy1981 mentioned this issue May 10, 2022
Closed
@mnlevy1981 mnlevy1981 linked a pull request May 10, 2022 that will close this issue
Improve diagnostics #403
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve diagnostics mnlevy1981/MARBL
1 participant
@klindsay28