Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements #1

Open
5 tasks done
dayanare opened this issue Dec 23, 2021 · 0 comments
Open
5 tasks done

Some improvements #1

dayanare opened this issue Dec 23, 2021 · 0 comments

Comments

@dayanare
Copy link

dayanare commented Dec 23, 2021

Really cool job @mararochafernandez !!!

excellent work! 😀

Here you have some tips to improve the exercise:

JavaScript: basic

  • Fix the if's structure: check for one option, then the other and then for the rest is enough with an else statement.
  • Use ONE addEventListener for each event. If you need to execute multiple functions at once perhaps you can call them inside your unique handler.

JavaScript: advanced

  • Check if the <select> has the default option (with no value).¡

HTML

  • Don't leave attributes with empty value.

CSS

  • Avoid adding styles until the js code is solid as a rock.

Further challenges

Then you can improve the game as you please, here you have some ideas:

  • Show an image with the user and computer selection
  • Make the input work when selecting the option.
  • Add a reset button that cleans the select, the counter and writes the initial feedback
  • Whatever you want!

Call to action

Let me know if you have any doubts ;)

Go for it!!

mararochafernandez added a commit that referenced this issue Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant