Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update document file names for outside links #1018

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Conversation

sharkAndshark
Copy link
Collaborator

  • Remove chapter numbers
  • Update file name of using-endpoints.md back
  • Update links

@nyurik
Copy link
Member

nyurik commented Nov 21, 2023

.md is required - try running it with just book and you will see empty pages

@sharkAndshark sharkAndshark marked this pull request as draft November 21, 2023 07:08
@nyurik
Copy link
Member

nyurik commented Nov 21, 2023

i made a pr against your branch - please review and merge

@nyurik nyurik marked this pull request as ready for review November 21, 2023 07:40
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@nyurik nyurik enabled auto-merge (squash) November 21, 2023 07:40
@nyurik nyurik disabled auto-merge November 21, 2023 07:40
@nyurik nyurik enabled auto-merge (squash) November 21, 2023 07:41
a few link fixes and other reverts for docdoc branch
@sharkAndshark
Copy link
Collaborator Author

i made a pr against your branch - please review and merge

Merged. : )

@sharkAndshark
Copy link
Collaborator Author

Defintely we need link checks in ci. It's easy to miss links... @nyurik

@nyurik nyurik merged commit 566e8fa into maplibre:main Nov 21, 2023
16 of 17 checks passed
@sharkAndshark sharkAndshark deleted the docdoc branch November 21, 2023 08:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants