Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MapLibre GL JS to d8cf29023392b7de85b365cdc17e50ae263a357c #361

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jul 5, 2022

No description provided.

@wipfli
Copy link
Contributor

wipfli commented Jul 5, 2022

This one introduces some failing tests...

➜  maplibre-gl-native git:(update-gl-js-to-d8cf29023392b7de85b365cdc17e50ae263a357c) ✗ cat render-test.log | grep "* failed"
* failed render-tests/runtime-styling/image-update-pattern
* failed render-tests/runtime-styling/image-add-pattern
* failed render-tests/regressions/mapbox-gl-js#5978
* failed render-tests/regressions/mapbox-gl-js#3107
* failed render-tests/regressions/mapbox-gl-native#9976
* failed render-tests/regressions/mapbox-gl-js#8273
* failed render-tests/regressions/mapbox-gl-js#2533
* failed render-tests/icon-text-fit/enlargen-both
* failed render-tests/line-pattern/pitch
* failed render-tests/line-pattern/step-curve
* failed render-tests/line-pattern/zoom-expression
* failed render-tests/line-pattern/property-function
* failed render-tests/line-pattern/literal
* failed render-tests/line-pattern/overscaled
* failed render-tests/line-pattern/@2x
* failed render-tests/fill-opacity/property-function-pattern
* failed render-tests/fill-pattern/case-data-expression
* failed render-tests/fill-pattern/wrapping-with-interpolation
* failed render-tests/fill-pattern/uneven-pattern
* failed render-tests/fill-pattern/@2x

@ntadej
Copy link
Collaborator

ntadej commented Jul 5, 2022

It will be hard to rebase those MRs. They may also contain less changes. I would wait that the first one is merged before opening more.

@wipfli
Copy link
Contributor

wipfli commented Jul 5, 2022

This is the associated commit in GL JS: maplibre/maplibre-gl-js@d8cf290

@wipfli
Copy link
Contributor

wipfli commented Jul 5, 2022

I won't open more for now. This one is problematic already.

@ntadej
Copy link
Collaborator

ntadej commented Apr 11, 2023

I guess this PR can be closed and branch deleted?

@ntadej ntadej closed this Apr 11, 2023
@ntadej ntadej deleted the update-gl-js-to-d8cf29023392b7de85b365cdc17e50ae263a357c branch April 11, 2023 12:17
@wipfli
Copy link
Contributor

wipfli commented Apr 12, 2023

Yes, thanks @ntadej

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants