-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MapLibre GL JS submodule to v1.15.2 #309
Comments
Relevant files could be:
|
This commit from @petr-pokorny-1 could be relevant: 672f2d8 |
https://github.com/maplibre/maplibre-gl-native/pull/6/files shows some things from GL JS which are used in native... |
Lot's of testing stuff seems shared, @HarelM |
The commit hashes in the
|
I would like to run the |
Can you also confirm that the same set of tests is ignored in JS than in native? |
In native, depending on the platform different tests are ignored. For a full list, see https://github.com/maplibre/maplibre-gl-native/tree/main/metrics/ignores In GL JS, we might actually run all the render tests. See https://github.com/maplibre/maplibre-gl-js/blob/main/test/integration/render/render.test.ts ... |
@HarelM How do we handle ignored tests again in GL JS? I remember there was some discussion about removing ignored tests... |
eeefc070d7333b21b205be3882df9b2e3cd444d1 is in #360 |
d8cf29023392b7de85b365cdc17e50ae263a357c is in #361 |
e27049d87be346a4f67ef6956a5113d977de63d8 is in #362 |
We removed ignored tests. |
This seems like a difficult but important ticket. I assigned myself because I am going to spend some time looking into this, but don't let that hold anyone back working on this or assigning themselves as well. |
Is this still only trying to get MapLibre GL JS to lastest in the 1.X branch and not the current main 2.x/3.x release? If it was going to 2.x I also wanted to note the path to tests seems to have changed. If it is just to 1.X this is not an issue (yet) For example, in a linux build you can run tests with But in the current main branch of maplibre-gl-js that path has moved to I know there was also some discussion of moving these tests into this project...so maybe this would be fixed by doing that. |
The biggest issue is that we've observed breakage of tests when trying to update the version even in the 1.X branch. See some of the old open MRs. |
The strategy should probably be to update the GL JS submodule commit by commit and make sure everything works every time. So you would first go from Mapbox v1.x in March 2020 (where it is now) to something near December 2020 (time or fork). This period has some new features in GL JS from Mapbox but not so many. Then you would follow MapLibre v1 until something like August 2021 (TypeScript and v2). This period has almost no new features from MapLibre. And finally, you would follow MapLibre v2 until today. This time period also has very few new features. So the good news is that there is some work to be done around tooling, but the style spec did not change much since March 2020 and so there is not that crazy much work to be done feature-wise... |
188 commits until v1.14.0 I am looking what kind of issues we run into and will make more issues for the milestone. |
Note that the workflow does not run
https://github.com/maplibre/maplibre-gl-native/blob/main/.github/workflows/update-gl-js.yml |
Change of plans. #938 |
I would like to update the MapLibre GL JS submodule to the latest 1.x version. This will probably affect the shaders and the style spec.
The text was updated successfully, but these errors were encountered: