-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement replace-all expression #2059
Conversation
Bundle size report: Size Change: +22 B
ℹ️ View Details
|
This PR and #2064 will be discussed tomorrow in the TSC meeting, feel free to join and present your point of view. |
Thanks to the committee for hearing out the OSM Americana project’s perspective at the meeting today. To recap:
Some counterpoints raised during the call; please correct me if I’ve misrepresented anything:
There were some other points made about arrays in vector tiles that were more germane to #2064 and nyurik/future-mvt#1. More details in the meeting minutes. |
We are moving the spec to its own repo. |
Closing per #2059 (comment) |
Unblocks osm-americana/openstreetmap-americana#680
This PR implements a
replace-all
expression for strings. This functionality is needed to efficiently support name delimiters as described in the osm-americana ticket "raise semi-colon limit on lists".The expression works as follows:
['replace-all', 'cats;dogs', ';', ' / ']
This takes the string
cats;dogs
and replaces the;
character, replacing it with/
and producingcats / dogs
.This is my first maplibre PR, so please help me out if I haven't done anything correctly!
Launch Checklist
CHANGELOG.md
under the## main
section.