Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise limit on semicolons in lists #680

Open
1ec5 opened this issue Jan 12, 2023 · 0 comments
Open

Raise limit on semicolons in lists #680

1ec5 opened this issue Jan 12, 2023 · 0 comments
Labels
enhancement New feature or request performance

Comments

@1ec5
Copy link
Member

1ec5 commented Jan 12, 2023

As of #666, the style replaces at most two semicolons in a value list with a human-readable separator:

https://github.com/ZeLonewolf/openstreetmap-americana/blob/82f8de644a895246ea3182a318238af9cb8a5bfe/src/constants/label.js#L247-L253

This is based on the statistics in #666 (comment) and #666 (comment) that show a dropoff in the occurrence of more than one or two semicolons. However, in theory, some very prominent features could have multiple names to label. Unfortunately, the magnificent workaround for the lack of a string replacement expression operator requires recursion to produce the expression, and it isn’t possible to recurse indefinitely, let alone performantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

No branches or pull requests

2 participants