Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add same layer test #114

Merged
merged 4 commits into from
Jul 20, 2021
Merged

add same layer test #114

merged 4 commits into from
Jul 20, 2021

Conversation

Gerdie
Copy link

@Gerdie Gerdie commented Jul 19, 2021

  • fixes bug where compositing 2 tilesets with the same layer names, but selecting different layers from each, would ignore the second tileset's layers even if the first tileset's layers were dropped.
  • adds test for same layer names

Next steps:

  • get PR approved
  • release 0.5.1
  • merge

@Gerdie
Copy link
Author

Gerdie commented Jul 20, 2021

test-same-layer-names benchmarks:

1: single tile in/out ... 33333 runs/s (30ms)
2: two different tiles at the same zoom level, zero buffer ... 5348 runs/s (187ms)
3: two different tiles from different zoom levels (separated by one zoom), zero buffer ... 1348 runs/s (742ms)
4: two different tiles from different zoom levels (separated by more than one zoom), zero buffer ... 2849 runs/s (351ms)
5: tiles completely made of points, overzooming, no properties ... 17544 runs/s (57ms)
6: tiles completely made of points, same zoom, no properties ... 100000 runs/s (10ms)
7: tiles completely made of points, overzoooming, lots of properties ... 12500 runs/s (80ms)
8: tiles completely made of points, same zoom, lots of properties ... 41667 runs/s (24ms)
9: buffer_size 128 - tiles completely made of points, same zoom, lots of properties ... 35714 runs/s (28ms)
10: tiles completely made of linestrings, overzooming and lots of properties ... 3003 runs/s (333ms)
11: tiles completely made of polygons, overzooming and lots of properties ... 641 runs/s (1559ms)
12: tiles completely made of points and linestrings, overzooming and lots of properties ... 24390 runs/s (41ms)
13: buffer_size 128 - tiles completely made of points and linestrings, overzooming and lots of properties ... 21277 runs/s (47ms)
14: tiles completely made of points and linestrings, overzooming (2x) and lots of properties ... 34483 runs/s (29ms)
15: tiles completely made of polygons, overzooming and lots of properties ... 2304 runs/s (434ms)
16: tiles completely made of polygons, overzooming (2x) and lots of properties ... 4878 runs/s (205ms)
17: buffer_size 4096 - tiles completely made of polygons, overzooming (2x) and lots of properties ... 2326 runs/s (430ms)
18: single tile, dropping layers ... 33333 runs/s (30ms)

master benchmarks:

1: single tile in/out ... 34483 runs/s (29ms)
2: two different tiles at the same zoom level, zero buffer ... 5000 runs/s (200ms)
3: two different tiles from different zoom levels (separated by one zoom), zero buffer ... 1391 runs/s (719ms)
4: two different tiles from different zoom levels (separated by more than one zoom), zero buffer ... 2874 runs/s (348ms)
5: tiles completely made of points, overzooming, no properties ... 17241 runs/s (58ms)
6: tiles completely made of points, same zoom, no properties ... 100000 runs/s (10ms)
7: tiles completely made of points, overzoooming, lots of properties ... 12346 runs/s (81ms)
8: tiles completely made of points, same zoom, lots of properties ... 41667 runs/s (24ms)
9: buffer_size 128 - tiles completely made of points, same zoom, lots of properties ... 40000 runs/s (25ms)
10: tiles completely made of linestrings, overzooming and lots of properties ... 3049 runs/s (328ms)
11: tiles completely made of polygons, overzooming and lots of properties ... 641 runs/s (1561ms)
12: tiles completely made of points and linestrings, overzooming and lots of properties ... 24390 runs/s (41ms)
13: buffer_size 128 - tiles completely made of points and linestrings, overzooming and lots of properties ... 23256 runs/s (43ms)
14: tiles completely made of points and linestrings, overzooming (2x) and lots of properties ... 23810 runs/s (42ms)
15: tiles completely made of polygons, overzooming and lots of properties ... 2294 runs/s (436ms)
16: tiles completely made of polygons, overzooming (2x) and lots of properties ... 4831 runs/s (207ms)
17: buffer_size 4096 - tiles completely made of polygons, overzooming (2x) and lots of properties ... 2336 runs/s (428ms)
18: single tile, dropping layers ... 38462 runs/s (26ms)

@Gerdie Gerdie marked this pull request as ready for review July 20, 2021 17:01
@Gerdie Gerdie requested a review from a team as a code owner July 20, 2021 17:01
@Gerdie
Copy link
Author

Gerdie commented Jul 20, 2021

Updated api-vt staging with this dev release and the results look good:

https://hey.mapbox.com/xray-debug/?left=mapbox.auto-v1-stg@staging&right=mapbox.auto-v1@staging#14.11/37.36897/-121.93409

https://hey.mapbox.com/xray-debug/?left=mapbox.auto-v1-stg@staging&right=mapbox.mapbox-streets-v8@staging#16.49/36.668135/-121.660975

Copy link

@manoharuss manoharuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the xray-debug tilesets side by side and confirmed the road date in auto-v1-stg is coming from auto-v1 correctly @Gerdie.

frc is a auto-v1 only property. Other Auto-v1 layers like poi_label look correct too. Thanks for unblocking us 🙇
image

@Gerdie Gerdie merged commit 04f7122 into master Jul 20, 2021
@Gerdie Gerdie deleted the test-same-layer-names branch July 20, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants