Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.4.0 #108

Merged
merged 5 commits into from
Jun 11, 2021
Merged

V0.4.0 #108

merged 5 commits into from
Jun 11, 2021

Conversation

artemp
Copy link
Contributor

@artemp artemp commented Feb 22, 2021 •
edited
Loading

  • @mapbox/node-pre-gyp >= v1.0.0
  • node-addon-api >= v3.1.0
  • node-mapnik >= 4.5.6
  • add missing @mapbox/vt2geojson (used in clipping.test.js)

/cc @springmeyer @mapsam

@artemp
Check tile_buffer is not empty before de-referencing
cd1d2b0
@artemp
Version 0.4.0
8bf3cab 
+ upgrade to `@mapbox/node-pre-gyp` >= v1.0.0
+ `node-addon-api` >= v3.1.0
+ `node-mapnik` >= 4.5.6
+ add missing `@mapbox/vt2geojson` (used in `clipping.test.js`)
@artemp artemp requested a review from a team as a code owner February 22, 2021 10:21
springmeyer
springmeyer reviewed Feb 22, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
springmeyer
springmeyer reviewed Feb 22, 2021
View reviewed changes
Copy link
Contributor

@springmeyer springmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding a changelog entry, and publishing binaries git commit --allow-empty -m "[publish binary]" this seems ready to merge & release. But I'll defer to the owning team (@mapbox/tilesets-api) for formal approval.

mapsam
mapsam approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@mapsam mapsam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @artemp! I'll merge and release 0.4.0 today, so we can grab these changes with our work in #112

Codecov failures look fine to me, I've removed the required status check from the repo since currently codecov is disabled after the security incident https://about.codecov.io/security-update/

@mapsam mapsam merged commit 05431d7 into master Jun 11, 2021
@mapsam mapsam deleted the v0.4.0 branch June 11, 2021 16:24
@mapsam mapsam mentioned this pull request Jun 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@springmeyer springmeyer springmeyer left review comments

@mapsam mapsam mapsam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemp @springmeyer @mapsam