Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect "fully within" test #95

Closed
artemp opened this issue Feb 19, 2019 · 0 comments
Closed

Incorrect "fully within" test #95

artemp opened this issue Feb 19, 2019 · 0 comments
Assignees
@artemp
Labels
bug Something isn't working

Comments

@artemp
Copy link
Contributor

artemp commented Feb 19, 2019 •
edited
Loading 

// only clip if not fully within bbox
if (bbox_.min.x >= extent_.min.x &&
    bbox_.max.x <= extent_.max.x &&
    bbox_.min.y >= extent_.min.y &&
     bbox_.max.y <= extent_.max.y)
{
    //...
}
else {
   // ...
}

The within test in feature_builder.hpp ^^ is bogus - bbox and extent needs swapping.
@artemp artemp self-assigned this Feb 19, 2019
@artemp artemp added the bug Something isn't working label Feb 19, 2019
@artemp artemp closed this as completed in 942a560 Feb 19, 2019
artemp added a commit that referenced this issue Feb 20, 2019
@artemp
add test [#95]
5bae50a
artemp added a commit that referenced this issue Feb 20, 2019
@artemp
move clipping test to vtcomposite.test.js [#95]
153982b
@artemp artemp mentioned this issue Mar 5, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemp artemp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artemp