Fix window padding function for changes to API of rasterio-1.0 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danshapero I'm sorry we've overlooked this for so long. The project has degraded and we no longer have a CI configured to test your changes. Combine that with a lack of long-term plans for this plugin and I'm hesitant to click merge. I need to discuss the future of this project with my team. If we're going to keep maintaining this plugin, a project infrastructure refresh will be followed immediately by a merge of this PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using rio-pansharpen from the command line recently and ran into an error because the
Windowclass no longer supports indexing. I think that class was changed from rasterio-0.36 to 1.0. In any case, this patch changes the window padding function in rio-pansharpen to work with the new rasterio API.