-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v6] Cocoapods (round two) #741
Conversation
Not sure if this is relevant, but my
with
does your PR resolve this error as well? For reference, here's a minimal project that reproduces the issue for me https://github.com/smoll/mapboxspike/tree/b1c61ca6d5566fe7ede26c02b036f76d4a5e1d6c Edit: hmm, is this because Podfiles are generally used for integrating Mapbox + RN with an existing ObjC/Swift project? Is it possible to not hardcode the |
@jesseditson Yes, |
@jesseditson I'll test this out today, are you good with me merging this in once I test it? |
I got some build errors on the example yesterday, so i’m gonna try to figure out what’s going on there today - maybe hold off until that’s building? I suspect you’ll run in to the same errors in your tests as well. Sorry for the churn, lots of moving parts getting npm and coda pods to play nice together. |
@jesseditson Should you try with empty repo then? |
Please prioritize this, needs to use cocoapods in our codebase 😅 |
@jesseditson let me know if you need help with this, I would be happy to help. I would also get this working on an empty repo since the example project has extra things set on it for local development. |
@henrikra yes! Part of my current TODO list RE: this PR is to make sure it installs clean after |
Ok, latest has been tested (and works) using the following steps:
When trying to get the |
@nitaliano Sorry again for the churn, LMK if I should file an issue about the example project, ignore it, or resolve in this PR! |
I think we can just remove anything pod related for the example project. I'd rather have another example project in a different repo that's setup to use pods |
Sounds reasonable! I'll clean that out, 1 sec |
Ok, example now has no cocoapods and is building. That said, it looks like it is not compatible with the v6 API (it errors trying to use MapboxGL.UserTrackingModes). Seems out of scope for this PR to fix that bit, but I'd imagine it'll be a fairly straightforward port. |
…nclude RCTImage subspec
3363018
to
d8ee12f
Compare
How is the progress of this? |
Should be ready to go! I'm running this branch on an active project, and it's working well. @nitaliano let me know if there's anything else you'd like me to update here! |
I get this when I run through your steps from previous post @jesseditson |
@ahmetabdi Just ran through the steps in this comment to make sure I didn't miss something! It worked for me, but the instructions aren't specific about what the Podfile should look like. What does your Podfile look like? My successful test had this podfile:
The error you have leads me to believe that the mapbox pod was not properly installed - perhaps try building via XCode to make sure the project does not error? Sometimes the errors can be hard to see when building via the CLI. |
Adding
Thanks @jesseditson |
Ah cool! Yeah the instructions are updated in this PR, but obviously that isn't on the main repo yet so I can understand the confusion! |
@jesseditson Hi, sorry this has taken long to merge in I've been working on another project. I will try to get this in today with a proper npm release after |
@jesseditson I just tried to run through the pods install and it's working great. We do need to make one change to this PR then we can merge it in. Would you be able to remove the changes made to the example apps xcode project file? It currently doesn't build due to some path changes |
@nitaliano no worries! This stuff takes time. Checked out the project from master, and tested the example build - looks good on my end, let me know if I can help with anything else! |
nope, LGTM thanks for the PR! |
Hello, When installing via CocoaPods I'm getting an error from xcode
My podfile is as follows:
When running
Thanks very much! |
I can try with the new version tomorrow, but in the meantime
I have tested cold on this branch, but not integrated in 6.0.1 or via upgrade yet, so thanks for posting here, and let me know how the clean install goes! |
Hi @jesseditson Thanks for your response :) I followed the steps provided, and unfortunately, it had no impact on the build which still fails with
|
Hey! So I tried a brand new project (even named it clustr) using your exact podfile and using this lib from npm, and it all builds ok for me. The only thing that stood out to me was the I'm curious, here's what the sidebar of my app looks like in XCode - does this match yours? Specifically, do you have a Did you update from an earlier version of |
If you are upgrading from a project where you had this library installed manually the header search paths that we're set to find Mapbox.framework could be the issue. If you have that set I would try removing it. |
Hi thanks, both @jesseditson and @nitaliano for your responses, I've been able to run through this again this evening. Firstly @jesseditson mine is similiar to yours, and I appreciate the effort you went through to help both of you and continue to do so. I attempted to run So just to clarify there are two apporaches to installing mapbox for ios; via CocoaPods or Manual? I've tried both and had no luck, it seems that even when running the manual installation, I get odd and various errors such as |
After removing the project, cloning again, running npm install, and Update #860 seems related to libc++abi.dylib: terminating with uncaught exception of type NSException (lldb) |
Prior PR had a few issues, didn't find them until today when I realized my test environment wasn't exactly clean (I had manually integrated this lib, so some headers that should have been missing were not!)
I'm not sure if excluding the
RCTSource
andRCTLayer
is preferable to deleting them, since they don't seem to be used anywhere. Should I just remove the files instead?Otherwise, this PR should get cocoapods into a truly working state.