More to Attach style brace formatting #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind providing
clang-format
support in node-cpp-skel is not as much to enforce a single style but more to make it easy for downstream modules to be able to enforce a consistent style. However it became clear when forward porting dawg-cache (mapbox/dawg-cache#23 (comment)) that this style for braces is preferable, so I think we should update skel accordingly:Rather than:
/cc @apendleton @GretaCB @mapsam