Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bench scripts for async examples #61

Merged
merged 4 commits into from
Aug 15, 2017
Merged

Add bench scripts for async examples #61

merged 4 commits into from
Aug 15, 2017

Conversation

GretaCB
Copy link
Contributor

@GretaCB GretaCB commented Aug 10, 2017 •
edited
Loading

Per #29 (comment), this is the first bench iteration.

Next Actions

  • Add docs
  • Add contextual comments

cc @springmeyer

@springmeyer springmeyer mentioned this pull request Aug 11, 2017
Open
springmeyer
springmeyer approved these changes Aug 15, 2017
View reviewed changes
Copy link
Contributor

@springmeyer springmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent:

  • benchmarking scripts look good, run well, show > 90% CPU utilization in the threads 🎉
  • very clear docs given how concise they are.

@GretaCB GretaCB merged commit d4bd145 into master Aug 15, 2017
This was referenced Aug 25, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@springmeyer springmeyer springmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GretaCB @springmeyer