Silence locationManager warning #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
suggested changes
May 1, 2017
| @@ -1,3 +1,4 @@ | |||
| #pragma clang diagnostic ignored "-Wincomplete-implementation" | |||
There was a problem hiding this comment.
This silences the diagnostic for every file that includes this header and thus every project that includes this SDK. Use clang diagnostic push and clang diagnostic pop to scope this pragma to just the lines that need it. See this article for more information about diagnostic pragmas.
|
@1ec5 good call, fixed |
1ec5
approved these changes
May 1, 2017
There was a problem hiding this comment.
I forgot one more thing: let’s add a comment referencing mapbox/mapbox-gl-native#6867 so that people know why we’re doing something as hacky as suppressing a compiler warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #172