Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapboxNavigation podspec fails validation #172

Closed
1ec5 opened this issue Apr 25, 2017 · 2 comments
Closed

MapboxNavigation podspec fails validation #172

1ec5 opened this issue Apr 25, 2017 · 2 comments
Labels
build Issues related to builds and dependency management.

Comments

@1ec5
Copy link
Contributor

1ec5 commented Apr 25, 2017

MapboxNavigation.podspec fails CocoaPods validation due to some warnings. (I have to pass --allow-warnings every time I push the podspec to trunk.) Some of these warnings are upstream in AWSCore and Pulley. The warnings in MGLMapView+MGLNavigationAdditions.h are caused by the hack in #57. Until mapbox/mapbox-gl-native#6867 is fixed, we should silence the warning using #pragma clang compiler directives.

Validating podspec
 -> MapboxNavigation (0.3.0)
    - WARN  | xcodebuild:  AWSCore/AWSCore/Fabric/Fabric.h:43:11: warning: parameter 'kits' not found in the function declaration [-Wdocumentation]
    - NOTE  | xcodebuild:  AWSCore/AWSCore/Fabric/Fabric.h:43:11: note: did you mean 'kitClasses'?
    - WARN  | xcodebuild:  Pulley/PulleyLib/PulleyViewController.swift:747:94: warning: 'FLT_EPSILON' is deprecated: Please use 'Float.ulpOfOne' or '.ulpOfOne'.
    - WARN  | xcodebuild:  Pulley/PulleyLib/PulleyViewController.swift:750:75: warning: 'FLT_EPSILON' is deprecated: Please use 'Float.ulpOfOne' or '.ulpOfOne'.
    - WARN  | xcodebuild:  AWSPolly/AWSPolly/AWSPollySynthesizeSpeechURLBuilder.h:200:9: warning: parameter 'configuration' not found in the function declaration [-Wdocumentation]
    - WARN  | xcodebuild:  AWSPolly/AWSPolly/AWSPollySynthesizeSpeechURLBuilder.h:217:9: warning: parameter 'preSignedURLRequest' not found in the function declaration [-Wdocumentation]
    - NOTE  | xcodebuild:  AWSPolly/AWSPolly/AWSPollySynthesizeSpeechURLBuilder.h:217:9: note: did you mean 'getPreSignedURLRequest'?
    - WARN  | xcodebuild:  MapboxNavigation/MapboxNavigation/MGLMapView+MGLNavigationAdditions.m:3:17: warning: method definition for 'locationManager:didUpdateLocations:' not found [-Wincomplete-implementation]
    - NOTE  | xcodebuild:  MapboxNavigation/MapboxNavigation/MGLMapView+MGLNavigationAdditions.h:6:1: note: method 'locationManager:didUpdateLocations:' declared here

[!] The spec did not pass validation, due to 6 warnings (but you can use `--allow-warnings` to ignore them).

/cc @frederoni @bsudekum

@1ec5 1ec5 added the build Issues related to builds and dependency management. label Apr 25, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented May 1, 2017

Let’s keep this open to track reporting and fixing the upstream warnings, since they block pushing to CocoaPods trunk without the special flag.

@1ec5
Copy link
Contributor Author

1ec5 commented Mar 18, 2019

This issue is long out of date: we removed the AWS SDK and Polly dependencies in #617 and the Polly dependency in #785.

@1ec5 1ec5 closed this as completed Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management.
Projects
None yet
Development

No branches or pull requests

1 participant