This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Add interface to add images to the style #6375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmpsantos, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @1ec5 and @incanus to be potential reviewers. |
jfirebaugh
suggested changes
Sep 19, 2016
There was a problem hiding this comment.
Related to mapbox/mapbox-gl-style-spec#220.
Based on the discussion there, we want to use "image" as an umbrella term that encompasses "icons" (e.g. icon-image) and "patterns" (e.g. background-pattern). Want to start with that naming convention here?
| @@ -161,6 +161,10 @@ class Map : private util::noncopyable { | |||
| void addLayer(std::unique_ptr<style::Layer>, const optional<std::string>& beforeLayerID = {}); | |||
| void removeLayer(const std::string& layerID); | |||
|
|
|||
| // Add icon, bound to the style | |||
| void addIcon(const std::string&, std::shared_ptr<const SpriteImage>); | |||
There was a problem hiding this comment.
Should be std::unique_ptr for consistency with addLayer and addSource.
tmpsantos
force-pushed
the
tmpsantos-add_icon
branch
from
b0c56dd
to
807be46
Compare
|
@jfirebaugh Thanks for reviewing. Changes made.
Makes sense. |
brunoabinader
changed the title
brunoabinader
approved these changes
Sep 22, 2016
Unlike annotations, they will go away when we change the style.
tmpsantos
force-pushed
the
tmpsantos-add_icon
branch
from
807be46
to
4d3356d
Compare
jfirebaugh
approved these changes
Sep 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike annotations, they will go away when we change the style. This API can also be used to change a sprite downloaded by a style at runtime.