This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Double maximum label width by reducing glyph precision. #11508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollymerp
approved these changes
Mar 22, 2018
| static_cast<int16_t>(::round(o.x * 64)), // use 1/64 pixels for placement | ||
| static_cast<int16_t>(::round((o.y + glyphOffsetY) * 64)) | ||
| static_cast<int16_t>(::round(o.x * 32)), // use 1/32 pixels for placement | ||
| static_cast<int16_t>(::round((o.y + glyphOffsetY) * 32)) |
There was a problem hiding this comment.
this seems to differ from the JS version, but it's not a new difference https://github.com/mapbox/mapbox-gl-js/pull/6375/files#diff-c3312919f069eefcab838ca0389b355aR108 – I think what's happening is you add the offset before oy is passed to the js addVertex function so they are in fact the same, but just flagging to making sure
There was a problem hiding this comment.
Yeah, this is supposed to be the equivalent logic in GL JS:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #11507.
Port of GL JS PR mapbox/mapbox-gl-js#6375.
/cc @tobrun @friedbunny @mollymerp @ansis @bsudekum