Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove platform specific Android code #15970

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Remove platform specific Android code #15970

merged 1 commit into from
Dec 3, 2019

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Nov 25, 2019 •
edited by chloekraw
Loading

All good things must come to an end: #15971

The Maps SDK for Android will live on in https://github.com/mapbox/mapbox-gl-native-android.

cc @tmpsantos @chloekraw @julianrex

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Nov 25, 2019
@tobrun tobrun requested a review from a team November 25, 2019 18:47
@tobrun tobrun self-assigned this Nov 25, 2019
langsmith
langsmith approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@langsmith langsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2019-11-25 at 12 54 27 PM

lol

@chloekraw chloekraw mentioned this pull request Nov 26, 2019
Merged
@tobrun
Copy link
Member Author

tobrun commented Nov 26, 2019

Noticing that I still need to cleanup the make file

@chloekraw chloekraw self-requested a review November 27, 2019 05:58
chloekraw
chloekraw approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@chloekraw chloekraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😯

@tobrun tobrun mentioned this pull request Nov 27, 2019
Closed
LukasPaczos
LukasPaczos approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 😭

@tmpsantos tmpsantos requested review from a team and removed request for a team November 27, 2019 15:07
tmpsantos
tmpsantos approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@tmpsantos tmpsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what is behind at platform/android/src we can remove ourselves. We are currently using the code for the test runner but I believe we don't need everything.

@tobrun tobrun mentioned this pull request Dec 3, 2019
Merged
This was referenced Dec 3, 2019
Closed
Closed
Closed
Closed
Closed
@tobrun tobrun merged commit 29bbfcc into master Dec 3, 2019
@tobrun tobrun deleted the tvn-goodbye branch December 3, 2019 16:10
This was referenced Dec 3, 2019
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmpsantos tmpsantos tmpsantos approved these changes

@langsmith langsmith langsmith approved these changes

@LukasPaczos LukasPaczos LukasPaczos approved these changes

@chloekraw chloekraw chloekraw approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tobrun @tmpsantos @langsmith @LukasPaczos @chloekraw