[android] Adding pulsing circle to LocationComponent options

[langsmith]

This pr adds a pulsing circle functionality to the Android LocationComponent.

The following options/methods have been added to LocationComponentOptions for styling the pulsing circle:

• whether the pulsing circle is enabled or not
• circle's color
• circle's opacity
• number of milliseconds of length of a single pulse
• type of interpolated animation (linear, decelerate, accelerate, or bounce)
• whether the circle's opacity fades during the pulse

Fade enabled:

Fade disabled:

[langsmith]

Still definitely a work in progress but opening this pr to start discussion and review from @mapbox/maps-android . Not sure whether my implementation is correct. Once things are 👌 on the back end, I can finish the test app example, write tests, finish Javadocs, etc.

Also, as you'll see in the fade enabled GIF above, there's a weird "hitch" when a pulse is finished and a new one is about to begin. I assume it probably has to do with how I'm tracking things in the PulsingLocationCircleAnimator class. Any thoughts on a better way to achieve this effect? Something to do with the speed of the ValueAnimator and the Maps SDK's ability to catch up with new values?

[langsmith]

I've got https://github.com/mapbox/mapbox-gl-native/pull/13942/files#diff-e6b14cce649c4c464b5c466cbda57938R76 , which is used here and then ultimately here. Doesn't seem to be working though. If you open the pulsing circle test app activity and then go back, it'll crash the app:

2019-02-18 16:11:09.093 29293-29293/? A/libc: Fatal signal 6 (SIGABRT), code -6 (SI_TKILL) in tid 29293 (pboxsdk.testapp), pid 29293 (pboxsdk.testapp)

Thoughts on how I might manage lifecycle with this background runnable and all?...

[tobrun]

sub module pins were updated but not required for this PR?
might be good to refactor all the pulsing fields into a new object?

[langsmith]

sub module pins were updated but not required for this PR?

Yes, they snuck in here 😢

[langsmith]

might be good to refactor all the pulsing fields into a new object?

Yea, wasn't sure whether we should have completely separate builder or not for these pulsing options. I didn't make one as a start, 'cause it might be too many nested builders into one another. 3 levels deep: PulsingCircleOptions into LocationComponentOptions and then LocationComponentOptions into LocationComponentActivationOptions. Thoughts? @LukasPaczos ?

[langsmith]

Yea, wasn't sure whether we should have completely separate builder or not for these pulsing options

Note: @LukasPaczos followed up offline and confirmed that the current setup is fine. Pulsing options can be in LocationComponentOptions rather than being part of another builder process.

[langsmith]

Status update. Things are looking great. I've added a number of different tests but I'm wrestling with a weird testing bug that's happening during the building of LocationComponentOptions.

  java.lang.IllegalArgumentException: You cannot set both layerAbove and layerBelow options. Choose one or the other.
        at com.mapbox.mapboxsdk.location.LocationComponentOptions$Builder.build(LocationComponentOptions.java:1300)
        at com.mapbox.mapboxsdk.location.LocationComponentOptions.createFromAttributes(LocationComponentOptions.java:373)
        at com.mapbox.mapboxsdk.location.LocationComponentOptions.builder(LocationComponentOptions.java:398)
        at com.mapbox.mapboxsdk.location.LocationAnimatorCoordinatorTest.setUp(LocationAnimatorCoordinatorTest.kt:42)

The pulsing now continues after returning to the activity from a different app. Pulsing now stops when the LocationComponent is deactivated and the pulsing resumes when the LocationComponent is reactivated. Pulsing also resumes when the map style has changed.

cancelPulsingCircleAnimation() is now working. It cancels the pulsing animator and hides the pulsing circle's layer.

Along with CustomizedLocationPulsingCircleActivity, which has the speed/color toggle, I've added BasicLocationPulsingCircleActivity. It shows the basic default pulsing circle:

[langsmith]

Ok @LukasPaczos , things are looking good visually and all tests are passing. This is ready for yet another round of review when you have the time and are in the mood.

old stale review

[patrickkempff]

Looks good! Looking forward to use this. Any updates when this PR will be merged? 👍

[tobrun]

We are removing platform code from gl-native in #15970. If you want to see this PR merged, it will require re-implementation in https://github.com/mapbox/mapbox-gl-native-android.

[DntPullALockett]

@malwoodsantoro When can we get this re implemented?

[langsmith]

For anyone following this pr and/or interested in using this feature, you should know that this feature has been added to the Mapbox Maps SDK for Android at mapbox/mapbox-gl-native-android#172.

The current Mapbox Maps SDK for Android is in the https://github.com/mapbox/mapbox-gl-native-android repository because the Mapbox team decided to move the Maps SDK for Android to a standalone repo: #15971

[Cloud9Clone]

When the new version 9.2.0. will be officially announced? I see that on the Mapbox page stays still 9.1.0.

[langsmith]

Hey @Cloud9Clone, 9.2.0 is out and available. It went out yesterday https://github.com/mapbox/mapbox-gl-native-android/releases/tag/android-v9.2.0

https://docs.mapbox.com/android/maps/overview/ and other docs pages just haven't been updated yet.

Docs about pulsing LocationComponent are at the bottom of the https://docs.mapbox.com/android/maps/overview/location-component/#active-styling-options section.