Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

update emerald marker swatch, misc updates to emerald and streets #1492

Closed
wants to merge 1 commit into from

Conversation

peterqliu
Copy link
Contributor

fixes #1489

also rolls in some minor style updates that we had put off til post-launch, but they seem 👌 while testing them as custom styles. If need be, we can update only the sprite assets, to avoid potential breakage.

cc/ @1ec5 @incanus

@1ec5
Copy link
Contributor

1ec5 commented May 10, 2015

So far so good with Emerald. What should I look out for when testing mapbox/mapbox-gl-styles@27e8ee8?

@peterqliu
Copy link
Contributor Author

@nickidlugash ^

@incanus
Copy link
Contributor

incanus commented May 11, 2015

If need be, we can update only the sprite assets, to avoid potential breakage.

We should probably play it conservative and go with that. As for approach, one idea is that we could maintain a branch in mapbox-gl-styles that we roll into the shipping GL.

@incanus
Copy link
Contributor

incanus commented May 11, 2015

We've got offset problems now:

ios simulator screen shot may 11 2015 9 04 33 am

@peterqliu
Copy link
Contributor Author

@incanus those don't look like the markers in the swatch-- did we switch out?

image

@1ec5
Copy link
Contributor

1ec5 commented May 11, 2015

@incanus, maybe you’re running into #1488? That can happen if you use the gear menu to add annotations, then change from Mapbox Streets to Emerald, then cause a redraw by zooming or panning. It wouldn’t be a regression if that’s the case.

@1ec5
Copy link
Contributor

1ec5 commented May 11, 2015

@jfirebaugh and I are unable to reproduce the annotation artifacting in either the beta 1 branch or in the same version of the internal test app that I originally spotted this issue in. So it might be dependent on a more specific set of steps.

@nickidlugash
Copy link
Contributor

What should I look out for when testing mapbox/mapbox-gl-styles@27e8ee8?

@1ec5 Sounds like you guys decided not to add this change into the release, but this change just splits up the water_label layer into two layers, filtered by area. One layer is styled the same as the original, the other just has a different min-zoom and text-size, so I imagine it shouldn't break anything.

@jfirebaugh
Copy link
Contributor

Moving to #1506 instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rectangular park draws to the south of any annotation on Emerald
5 participants