Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

resolve callout offset issues #1511

Closed
incanus opened this issue May 11, 2015 · 1 comment
Closed

resolve callout offset issues #1511

incanus opened this issue May 11, 2015 · 1 comment
Labels
bug iOS Mapbox Maps SDK for iOS
Milestone

Comments

@incanus
Copy link
Contributor

incanus commented May 11, 2015

Per #1506 (comment) we should resolve callout offset issues in master to avoid regressions.

#1492 (comment)

@incanus incanus added bug iOS Mapbox Maps SDK for iOS labels May 11, 2015
@incanus incanus added this to the iOS Beta 2 milestone May 11, 2015
@incanus
Copy link
Contributor Author

incanus commented May 11, 2015

The perceived offset issues are actually a manifestation of #1488, which is really two problems: marker images can disappear, and marker images can be at a mismatch with the current style. When they are a mismatch with the current style (e.g. showing Streets' smaller markers on Emerald), the JSON & image don't match up and so the callout is placed wrong.

Repro in GL demo app:

  1. Start with Streets
  2. Add 100 annotations
  3. Switch to Emerald
  4. Marker imagery remains Streets
  5. Tap marker and observe callout dislocation

Workaround:

  1. Start with Streets
  2. Switch to Emerald
  3. Add 100 annotations
  4. Marker imagery is Emerald
  5. No callout problems.

#1488 adequately covers our bases.

@incanus incanus closed this as completed May 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

1 participant