Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable letter-spacing for Arabic text (issue #4208) #4727

Merged
merged 1 commit into from
May 19, 2017

Conversation

ChrisLoer
Copy link
Contributor

Disables letter-spacing for Arabic text as discussed in issue #4208.

Two things to note:

  • The decision to space or not to space is done on a per-feature level, instead of being done at word boundaries, which might make more sense for diglossic labels. I could make an argument that consistent spacing within the feature is a good thing, but mainly this is just significantly easier to implement.
  • The PR only addresses Arabic, where there's a known problem. I haven't done an inventory of other scripts where this might be a problem. To be fully aware of when letter spacing is allowed, we'd need to work with the font (i.e. using Harfbuzz to render text).

/cc @1ec5 @nickidlugash @jcsg

@1ec5
Copy link
Contributor

1ec5 commented May 19, 2017

The PR only addresses Arabic, where there's a known problem.

That’s fine, since Arabic is the only writing system for which we support ligatures at the moment.

Copy link

@nickidlugash nickidlugash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ChrisLoer ChrisLoer merged commit a1f4938 into master May 19, 2017
@ChrisLoer ChrisLoer deleted the cloer_no_arabic_letter_spacing branch May 19, 2017 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants