-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable letter-spacing for Arabic text #4208
Comments
@ajashton previously presented and blogged about an approach in CartoCSS that uses word spacing instead of letter spacing in scripts such as Arabic and Bengali. While not as sophisticated as the swashes found in traditional Arabic cartography, this approach is more generalizable and avoids font considerations. See also:
|
Also interesting: W3C documents on letter spacing and typographic character units. As a first pass, might it be ok to simply disable letter-spacing for Arabic (and other affected scripts)? I think that not having broken text on maps using our platform is an acceptable first goal, and that supporting any alternative formatting (word spacing, swashes, etc) could be done in a separate update.
Perhaps – personally, though, I don't think this is a big deal, at least compared to the alternative of inadvertently displaying broken Arabic text. We could perhaps just add a disclaimer to the documentation on this style spec property.
While this is true, and internally we've avoided using |
Fixed with #4727 |
Styles that increase letter-spacing don't play nice with languages where the glyphs are meant to be in contact with each other (Arabic now, Hindi and others in the future). For now this is a problem that can always be addressed with a style modification, but it's something we shouldn't make style editors think about.
Not sure if we would need to surface this change in Studio in any explicit way. Once we fix https://github.com/mapbox/studio/issues/8396, the preview should show designers what's happening. It still might be a surprise if increased letter spacing didn't do anything to Arabic text -- not that the designer would expect it to be spaced, but just that they wouldn't think about the difference ahead of time.
@tmcw @1ec5
The text was updated successfully, but these errors were encountered: