This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Refactoring and splitting basic SymbolLayer icon examples #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langsmith
force-pushed
the
ls-adding-basic-symbol-layer-example
branch
from
3fcf208
to
033426d
Compare
tobrun
reviewed
May 13, 2019
| } | ||
| return true; | ||
| } | ||
| mapboxMap.setStyle(new Style.Builder().fromUrl("mapbox://styles/mapbox/cjf4m44iw0uza2spb3q0a7s41") |
There was a problem hiding this comment.
could you add some context why we are using this specific style?
There was a problem hiding this comment.
Using a style that isn't found in Style class to just shake things up a little.
| if (mapboxMap != null) { | ||
| mapboxMap.removeOnMapClickListener(this); | ||
| } | ||
| mapView.onDestroy(); |
There was a problem hiding this comment.
we aren't stopping animations in this example so we can potentially crash with selecting a symbol and closing the activity quickly after.
There was a problem hiding this comment.
Ok, 4d4e13a adds animation cancellation in onDestroy().
There was a problem hiding this comment.
I closed the example during the icon size animation. No issues.
…xample to new one
langsmith
force-pushed
the
ls-adding-basic-symbol-layer-example
branch
from
033426d
to
b9402a6
Compare
|
Anything else, @tobrun ? |
tobrun
approved these changes
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only taken me two years to get around to it, but I've always felt like the current
BasicSymbolLayerActivityexample wasn't truly basic. Yes, it addedSymbolLayericons, but the example had logic to listen to map clicking, change select state, animate the icon size, etc.It's not a barebones and clean example of how to simply add
SymbolLayericons to the map with no other frills.This pr moves the
masterbranch'sBasicSymbolLayerActivitycode to an example titledIconSizeChangeOnClickActivityand then cuts out the fluff from theBasicSymbolLayerActivity. TheBasicSymbolLayerActivitynow just shows 3SymbolLayericons in Uruguay.cc @riastrad and @samfader for mobile support
cc @colleenmcginnis . This refactoring and code movement might make https://docs.mapbox.com/android/maps/examples/ a bit wonky. I will fix things downstream in
/android-docsonce this lands.