adding animation cancel in onDestroy

mapbox · May 13, 2019 · 4d4e13a · 4d4e13a
1 parent b9402a6
commit 4d4e13a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/...main/java/com/mapbox/mapboxandroiddemo/examples/styles/IconSizeChangeOnClickActivity.java b/...main/java/com/mapbox/mapboxandroiddemo/examples/styles/IconSizeChangeOnClickActivity.java
@@ -33,6 +33,7 @@
 public class IconSizeChangeOnClickActivity extends AppCompatActivity implements
   OnMapReadyCallback, MapboxMap.OnMapClickListener {
 
+  private ValueAnimator markerAnimator;
   private MapView mapView;
   private MapboxMap mapboxMap;
   private boolean markerSelected = false;
@@ -138,7 +139,7 @@ public boolean onMapClick(@NonNull LatLng point) {
   }
 
   private void selectMarker(final SymbolLayer iconLayer) {
-    ValueAnimator markerAnimator = new ValueAnimator();
+    markerAnimator = new ValueAnimator();
     markerAnimator.setObjectValues(1f, 2f);
     markerAnimator.setDuration(300);
     markerAnimator.addUpdateListener(new ValueAnimator.AnimatorUpdateListener() {
@@ -155,7 +156,6 @@ public void onAnimationUpdate(ValueAnimator animator) {
   }
 
   private void deselectMarker(final SymbolLayer iconLayer) {
-    ValueAnimator markerAnimator = new ValueAnimator();
     markerAnimator.setObjectValues(2f, 1f);
     markerAnimator.setDuration(300);
     markerAnimator.addUpdateListener(new ValueAnimator.AnimatorUpdateListener() {
@@ -207,6 +207,9 @@ protected void onDestroy() {
     if (mapboxMap != null) {
       mapboxMap.removeOnMapClickListener(this);
     }
+    if (markerAnimator != null) {
+      markerAnimator.cancel();
+    }
     mapView.onDestroy();
   }