-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing build toolchain setup code #12
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
node-cpp-skel now has a single method for setting up mason and the clang++ toolchain. It lives in https://github.com/mapbox/node-cpp-skel/blob/master/scripts/setup.sh and is used like:
The idea behind this script is to:
clang++
andmason
without worrying about the versions (which are controlled in the script)set -e
to stop on error, but sourcing will accidentally inherit this in the travis shell (and this cane break the travis build oddly). The output of setup.sh (akalocal.env
) is purelyexport
commands for variables. So this is safe to source without worrying about breaking the travis shell.Proposal
This
setup.sh
script is not specific to node addons, so we could start using and recommending it for all header only C++ libs.So, @mapsam what do you think about pulling it into hpp-skel and adapting the travis.yml to use it?
The text was updated successfully, but these errors were encountered: